[EXP][CMDBUF] Add support for recovering CommandBuffer profiling information #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linked DPC++ PR: intel/llvm#11324 |
mfrancepillois
force-pushed
the
cmd-buffer-profiling-l0
branch
from
7cf777a to
4808c63
Compare
EwanC
reviewed
Nov 9, 2023
mfrancepillois
changed the title
jandres742
reviewed
Nov 22, 2023
jandres742
reviewed
Nov 22, 2023
EwanC
approved these changes
Nov 28, 2023
|
@jandres742 Could you take another look at this PR and see if the responses to your questions are satisfactory. |
|
I have updated the target branch of this PR from the |
|
@jandres742 reminder that this PR is waiting on your review. |
jandres742
approved these changes
Dec 6, 2023
EwanC
added
ready to merge
Adds an extra event in the first command list associated to the CommandBuffer execution to obtain the start time of the graph execution.
Get the command-buffer start and end timestamps from this memory. Move events reset from the middle command list to the first to allow the copy of the profiling info in the last command list and relax command list order.
kbenzie
force-pushed
the
cmd-buffer-profiling-l0
branch
from
465197a to
35b6a5e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
- Coverage 15.74% 15.73% -0.01%
==========================================
Files 223 223
Lines 31478 31477 -1
Branches 3558 3558
==========================================
- Hits 4955 4954 -1
Misses 26472 26472
Partials 51 51 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy command-buffer event timestamps into a dedicated USM memory region.
Get the command-buffer start and end timestamps from this memory.
Move events reset from the middle command list to the first to allow the copy of the profiling info in the last command list and relax command list order.