xe: fix various GEMM issues on XeLP #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
petercad
reviewed
Jan 10, 2025
petercad
approved these changes
Jan 10, 2025
rjoursler
force-pushed
the
rjoursle/fix_gemm
branch
from
26fc01d to
c5ff175
Compare
Simplifies logic for which cases are supported. Additionally enables a few more simple conversions.
This is necessary for reading and writing accumulators with type s32.
rjoursler
force-pushed
the
rjoursle/fix_gemm
branch
from
c5ff175 to
40d9909
Compare
atkassen
approved these changes
Jan 10, 2025
rjoursler
force-pushed
the
rjoursle/fix_gemm
branch
from
40d9909 to
3cb2f1a
Compare
|
make test |
|
make test |
rjoursler
force-pushed
the
rjoursle/fix_gemm
branch
from
53dee17 to
392b587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an emulate gap uncovered by #2276 , a support gap uncovered by #2289, and fixes a type conversion issue uncovered by #2289.