-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(workflows): add skywalking-eyes
license header check
#2867
base: main
Are you sure you want to change the base?
Conversation
f16c204
to
7c41cfb
Compare
.github/.licenserc.yaml
Outdated
header: | ||
license: | ||
spdx-id: Apache-2.0 | ||
copyright-owner: contributors to the oneDAL project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it also check that older Intel copyright owner that still exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this field so it won't be confusing, as it's not used for check.
7c41cfb
to
6ceea9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume that overall check works and it would catch copyright that is not compliant
.github/.licenserc.yaml
Outdated
# Clang-format configs | ||
- '.clang-format' | ||
# All .md files | ||
- '**/*.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have md files with copyrights - should we keep them for check? How many failures?
Might be as a next pr discussion on exclusion - fine to merge this one as is
f785071
to
e102d97
Compare
e102d97
to
b0b12d4
Compare
b0b12d4
to
618b609
Compare
618b609
to
236f606
Compare
236f606
to
89ec518
Compare
No description provided.