test: Add CTS for Sysman memory diagnostics #137
+54
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related-To: VLCLJ-2372 Signed-off-by: B, Vishnu Khanth <[email protected]>
vishnu-khanth
force-pushed
the
diag_cts
branch
from
d3a8b66 to
9ce9f82
Compare
vishnu-khanth
requested review from
joshuaranjan,
pratikbariintel and
narenbagria
| auto properties = lzt::get_diag_properties(diag_handle); | ||
|
|
||
| if (strcmp(properties.name, "MEMORY_PPR") == 0) { | ||
| bool mem_diag_available = true; |
There was a problem hiding this comment.
Should this be using the declaration at Ln 257 ?
| uint32_t mem_handles_count = 0; | ||
| std::vector<zes_mem_handle_t> mem_handles = | ||
| lzt::get_mem_handles(device, mem_handles_count); | ||
| EXPECT_GT(mem_handles_count, 0); |
There was a problem hiding this comment.
Can we have verification to check mem_handles_count is same as before diagnostics ?
|
|
||
| for (auto mem_handle : mem_handles) { | ||
| ASSERT_NE(nullptr, mem_handle); | ||
| lzt::get_mem_state(mem_handle); |
| } | ||
|
|
||
| if (!diag_handles_available) { | ||
| FAIL() << "No handles found in any of the devices!"; |
| FAIL() << "Memory Diagnostics is not available for this device!"; | ||
| } | ||
| } else { | ||
| LOG_WARNING << "No handles found on this device!"; |
There was a problem hiding this comment.
Please specify what handles are not found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-To: VLCLJ-2372