fix: comply with revised GTEST_SKIP() guidelines #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matcabral
reviewed
Dec 17, 2024
matcabral
reviewed
Dec 17, 2024
matcabral
reviewed
Dec 17, 2024
narenbagria
force-pushed
the
metric
branch
2 times, most recently
from
cb478b3 to
136143d
Compare
matcabral
reviewed
Dec 18, 2024
|
please test these changes before committing since affects the pass rate |
|
Please avoid force push, it is super useful to be able to see the delta between patches instead of reviewing all over again. |
matcabral
previously approved these changes
Dec 18, 2024
Resolves: VLCLJ-2336 Signed-off-by: Bagria, Narendra <[email protected]>
I’ve verified the changes on two different platforms and there are no new failures, thank you. |
matcabral
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: VLCLJ-2336