fix: Removed the condition variable check from Sysman Memory CTS #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the call to fetch the memory and the RAS states, the condition variable check has been removed. Related-To: VLCLJ-2343 Signed-off-by: Pratik Bari <[email protected]>
pratikbariintel
force-pushed
the
memory_cts_fix
branch
from
d5cdc0f to
e3bfc16
Compare
pratikbariintel
changed the title
pratikbariintel
changed the title
|
The issue is previously deadlock was happening if one of the threads exit when handles not found. Is this right ? |
| for (auto mem_handle : mem_handles) { | ||
| ASSERT_NE(nullptr, mem_handle); | ||
| lzt::get_mem_state(mem_handle); | ||
| } | ||
| lock.unlock(); |
There was a problem hiding this comment.
now as per the changes we have get_mem_state & get_ras_state happening serially one after the other.
But do need to fetch mem state & ras state concurrently ?
There was a problem hiding this comment.
As we are launching get_mem_state and get_ras_state in the threads, it does not guarantee that one will run before/after the latter. Have removed the mutex lock/unlocks now which will facilitate concurrency.
Yes |
During the call to fetch the memory and the RAS states, the condition variable check has been removed. Related-To: VLCLJ-2343 Signed-off-by: Pratik Bari <[email protected]>
During the call to fetch the memory and the RAS states, the condition variable check has been removed. Related-To: VLCLJ-2343 Signed-off-by: Pratik Bari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the call to fetch the memory and the RAS states, the condition variable check has been removed.
Related-To: VLCLJ-2343
Signed-off-by: Pratik Bari [email protected]