-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FI-3100: Update (g)(10) Certfication Test Kit Terminology Package to 2024 Version #570
Conversation
.split('#') | ||
.prepend(REGISTRY_SERVER_URL) | ||
.join('/') | ||
package_url = if package.end_with?('#7.0.0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a strict check for the US Core 7 package.
FHIRPackageManager.get_package( | ||
'us.nlm.vsac#0.11.0', File.join(PACKAGE_DIR, 'vsac'), ['ValueSet', 'CodeSystem'] | ||
'us.nlm.vsac#0.17.0', File.join(PACKAGE_DIR, 'vsac'), ['ValueSet', 'CodeSystem'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the version of the VSAC package referenced in US Core 7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I think I was looking in the wrong place for this, I believe I found the correct version now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also have to regenerate everything from scratch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will re-run the terminology script again and push up any changes it potentially makes. I have been running it locally, do I need to do anything else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the g10 tests and verify that things look normal compared with what's on prod.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ran with the vsac package update and everything looks normal and works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources/value_sets.yml
needs to be updated to include the VS bindings from US Core 7. This basically involves adding all of the bindings from the US Core 7 metadata in the US Core Test Kit, and then removing duplicates.
Now you have to rerun the terminology generation. |
Running now, will let you know if there are any issues |
Ran the terminology generation again and everything looks good and works as expected |
This PR updates the related terminology script code to use the new 2024 UMLS terminology package version. Running the script now will pull down the 2024 UMLS package, and update the (g)(10) Test Kit to use the updated FHIR terminology. This also updates the
lib/inferno/terminology/expected_manifest.yml
file with the new number of values in the updated value sets so that thebundle exec rake terminology:check_built_terminology
runs without failure.Also created instructions for this process and added it as an attachment to the ticket for this task.