FI-3100: Update (g)(10) Certfication Test Kit Terminology Package to 2024 Version #570
Conversation
| .split('#') | ||
| .prepend(REGISTRY_SERVER_URL) | ||
| .join('/') | ||
| package_url = if package.end_with?('#7.0.0') |
There was a problem hiding this comment.
This should be a strict check for the US Core 7 package.
| FHIRPackageManager.get_package( | ||
| 'us.nlm.vsac#0.11.0', File.join(PACKAGE_DIR, 'vsac'), ['ValueSet', 'CodeSystem'] | ||
| 'us.nlm.vsac#0.17.0', File.join(PACKAGE_DIR, 'vsac'), ['ValueSet', 'CodeSystem'] |
There was a problem hiding this comment.
This is not the version of the VSAC package referenced in US Core 7.
There was a problem hiding this comment.
Oops I think I was looking in the wrong place for this, I believe I found the correct version now
There was a problem hiding this comment.
You'll also have to regenerate everything from scratch.
There was a problem hiding this comment.
Okay I will re-run the terminology script again and push up any changes it potentially makes. I have been running it locally, do I need to do anything else?
There was a problem hiding this comment.
Run the g10 tests and verify that things look normal compared with what's on prod.
There was a problem hiding this comment.
Re-ran with the vsac package update and everything looks normal and works as expected
|
Now you have to rerun the terminology generation. |
Running now, will let you know if there are any issues |
|
Ran the terminology generation again and everything looks good and works as expected |
This PR updates the related terminology script code to use the new 2024 UMLS terminology package version. Running the script now will pull down the 2024 UMLS package, and update the (g)(10) Test Kit to use the updated FHIR terminology. This also updates the
lib/inferno/terminology/expected_manifest.ymlfile with the new number of values in the updated value sets so that thebundle exec rake terminology:check_built_terminologyruns without failure.Also created instructions for this process and added it as an attachment to the ticket for this task.