Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FI-2372: Fix preset #476

Merged
merged 1 commit into from
Dec 13, 2023
Merged

FI-2372: Fix preset #476

merged 1 commit into from
Dec 13, 2023

Conversation

Jammjammjamm
Copy link
Contributor

It doesn't make sense for the preset within the g10 test kit to point at the same host as Inferno. It should just point to our deployed reference server.

@Jammjammjamm Jammjammjamm self-assigned this Dec 13, 2023
arscan
arscan approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@arscan arscan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, i noticed that when running the g10 tests against the new reference server locally, but forgot to try to track it down. Thanks!

@Jammjammjamm Jammjammjamm changed the title Fix preset FI-2372: Fix preset Dec 13, 2023
@Jammjammjamm Jammjammjamm merged commit b2366f4 into main Dec 13, 2023
3 checks passed
@Jammjammjamm Jammjammjamm deleted the fix-preset branch December 13, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arscan arscan arscan approved these changes

@yunwwang yunwwang Awaiting requested review from yunwwang

Assignees

@Jammjammjamm Jammjammjamm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jammjammjamm @arscan