Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly escape interpolation-like strings in resolved configs #1113

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

odelalleau
Copy link
Collaborator

@odelalleau odelalleau commented Aug 8, 2023

Fixes #1112
Fixes #1081

This is a draft PR for several reasons:

  1. It needs tests + news fragment
  2. It is built on top of Update pre-commit hooks and drop support for Python 3.6 & 3.7 #1109 that needs to be merged first
  3. The behavior of to_container() and to_object() needs to be looked at (see Escaped resolver modifying _root_ doesn't work #1120)

Note that this is a breaking change, but it can be argued that the previous behavior was a bug (all tests pass).

@odelalleau odelalleau requested a review from omry August 8, 2023 15:54
@odelalleau odelalleau marked this pull request as draft August 8, 2023 15:55
@odelalleau odelalleau requested a review from Jasha10 August 8, 2023 16:01
Copy link
Collaborator

@Jasha10 Jasha10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@omry
Copy link
Owner

omry commented Aug 14, 2023

I think this needs tests to show what it's actually doing and to ensure it does not break in the future.
Also, worth considering any performance impact.

@odelalleau
Copy link
Collaborator Author

I think this needs tests to show what it's actually doing and to ensure it does not break in the future.

Oh yes (see point 1 above)

Also, worth considering any performance impact.

I need to think about it a bit more, but I don't believe this is an issue. Will keep it in mind though.

@MatteoVoges
Copy link
Contributor

Hey I noticed a breaking change with this. See full description of it here: #1112 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior for multiline-strings Add is_unresolved to OmegaConf
4 participants