Better error message when pyproject.toml is broken #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lordmauve is this a helpful improvement? |
lordmauve
reviewed
Feb 3, 2025
| try: | ||
| data = tomli.loads(content).get("tool", {}).get("thx", {}) | ||
| except tomli.TOMLDecodeError as error: | ||
| raise ConfigError(f"failure parsing pyproject.toml: {str(error)}") from error |
There was a problem hiding this comment.
Maybe including the actual path could avoid confusion?
Suggested change
| raise ConfigError(f"failure parsing pyproject.toml: {str(error)}") from error | |
| raise ConfigError(f"failure parsing {pyproject}: {error}") from error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catches the parse error from tomli and wraps it in a ConfigError with an
error message making it clear that the error is from parsing
pyproject.tomlFixes: #135