Handle non existing deeplink app (#355)

* Handle browser termination on opening non existent app * Format * Format * Combine if statements Co-authored-by: Aashish Gurung <[email protected]> * Fix `if` syntax --------- Co-authored-by: Aashish Gurung <[email protected]>
omise · Sep 10, 2024 · 35ef80f · 35ef80f
1 parent dd8d70f
commit 35ef80f
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/sdk/src/main/java/co/omise/android/ui/AuthorizingPaymentActivity.kt b/sdk/src/main/java/co/omise/android/ui/AuthorizingPaymentActivity.kt
@@ -52,6 +52,7 @@ class AuthorizingPaymentActivity : AppCompatActivity() {
     private val uiCustomization: UiCustomization by lazy { intent.parcelable(EXTRA_UI_CUSTOMIZATION) ?: UiCustomization.default }
     private lateinit var threeDSRequestorAppURL: String
     private var isWebViewSetup = false
+    private var isDeepLinkSuccOpened = false
     private lateinit var externalActivityLauncher: ActivityResultLauncher<Intent>
 
     private val viewModel: AuthorizingPaymentViewModel by viewModels {
@@ -253,12 +254,14 @@ class AuthorizingPaymentActivity : AppCompatActivity() {
     }
 
     private fun openDeepLink(uri: Uri) {
-        try {
-            val externalIntent = Intent(Intent.ACTION_VIEW, uri)
-            externalActivityLauncher.launch(externalIntent)
-        } catch (e: ActivityNotFoundException) {
-            finishActivityWithFailure(OmiseException(OmiseSDKError.OPEN_DEEP_LINK_FAILED.value, e))
-        }
+        isDeepLinkSuccOpened =
+            try {
+                val externalIntent = Intent(Intent.ACTION_VIEW, uri)
+                externalActivityLauncher.launch(externalIntent)
+                true
+            } catch (e: ActivityNotFoundException) {
+                false
+            }
     }
 
     private fun setupActionBarTitle() {
@@ -302,7 +305,7 @@ class AuthorizingPaymentActivity : AppCompatActivity() {
         resultCode: Int,
         data: Intent?,
     ) {
-        if (requestCode == REQUEST_EXTERNAL_CODE) {
+        if (requestCode == REQUEST_EXTERNAL_CODE && isDeepLinkSuccOpened) {
             finishActivityWithSuccessful(data)
         }
     }