Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tailwind prettier/eslint conflict #56

Conversation

ahkhanjani
Copy link
Contributor

@ahkhanjani ahkhanjani commented Nov 20, 2024

#54

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shadcn-phone-input ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 7:28pm

remove directories already ignored by .gitignore
add pnpm-lock.yaml
Copy link
Owner

@omeralpi omeralpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the formatting instead of disabling the ESLint rule.
This would ensure consistent and clean code across the project.

Here suggestion;

.eslintrc.json Show resolved Hide resolved
prettier.config.mjs Outdated Show resolved Hide resolved
@omeralpi omeralpi merged commit e002057 into omeralpi:chore/integrate-code-quality-tools Nov 22, 2024
2 checks passed
@ahkhanjani ahkhanjani deleted the chore/eslint-prettier-tailwind-fix branch November 22, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants