Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop omero.version from zip name #6414

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 4, 2024

This PR removes the version from the zip name to simplify installation when downloading from GH
See ome/omero-install#292 for background

@sbesson
Copy link
Member

sbesson commented Nov 5, 2024

I understand the motivation to have a version-agnostic URL in the context of ome/omero-install#292 but I am concerned about the implications of dropping the version numbers from the server artifact.

The first one that comes to mind is the server upgrade process. With this change, the artifact would become OMERO.server-ice36.zip and be unpacked as OMERO.server-ice36 for any version. Extracting the binaries would then overwrite the same directory by default unless the former directory is itself renamed. In general I anticipate this would need modifications to the whole installation/upgrade instructions and it would be useful to look at the scope of these changes.

@will-moore
Copy link
Member

I wonder if this PR could be causing the build failure on merge-ci today?
https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-server/242/console

00:46:13   inflating: OMERO.server-5.6.3-522-bca4dbbfb5-ice36/sql/psql/OMERO5.4__0/views.sql  
00:46:13 + rm -f OMERO.server.zip
00:46:13 + mv /home/omero/workspace/OMERO-server/OMERO.server /home/omero/workspace/OMERO-server/OMERO.server
00:46:13 mv: cannot stat '/home/omero/workspace/OMERO-server/OMERO.server': No such file or directory
00:46:13 Build step 'Execute shell' marked build as failure

@jburel
Copy link
Member Author

jburel commented Nov 5, 2024

@sbesson
This PR will create zip without version in the name
see https://github.com/jburel/openmicroscopy/releases/tag/5.6.14-test
when you download and the OMERO.server.zip and unzip it, it will create a folder OMERO.server-xxxx-ice3.6 where xxx is the tag name. Only the name of the zip is modified by this PR not the rest i.e. it should not overwrite cf. your comment

@will-moore Probably a small adjustment to the build step but I will exclude the PR for now

@jburel
Copy link
Member Author

jburel commented Nov 5, 2024

--exclude

@sbesson
Copy link
Member

sbesson commented Nov 5, 2024

Understood, and the job log linked from #6414 (comment) confirms that the archive prefix is unmodified and would still include the version of the application. In that case, I would agree the impact of this change will not be as large as I raised. I still suspect some sections of the installation documentations would need to be adjusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants