Dev (#126)

* Log block height for balance changes

* Fix share traversal

* Log one address per line

src/MiningCore/Payments/PayoutManager.cs

@@ -157,7 +157,7 @@ await cf.RunTxAsync(async (con, tx) =>
             }
 
             else
-                logger.Info(() => $"No updated blocks for {pool.Id}");
+                logger.Info(() => $"No updated blocks for pool {pool.Id}");
         }
 
         private async Task PayoutPoolBalancesAsync(PoolConfig pool, IPayoutHandler handler)

src/MiningCore/Payments/PayoutSchemes/PayPerLastNShares.cs

@@ -99,7 +99,7 @@ public Task UpdateBalancesAsync(IDbConnection con, IDbTransaction tx, PoolConfig
 
                 if (amount > 0)
                 {
-                    logger.Info(() => $"Adding {payoutHandler.FormatAmount(amount)} to balance of {address} for {FormatUtil.FormatQuantity(shares[address])} ({shares[address]}) shares");
+                    logger.Info(() => $"Adding {payoutHandler.FormatAmount(amount)} to balance of {address} for {FormatUtil.FormatQuantity(shares[address])} ({shares[address]}) shares for block {block.BlockHeight}");
                     balanceRepo.AddAmount(con, tx, poolConfig.Id, poolConfig.Coin.Type, address, amount);
                 }
             }
@@ -111,7 +111,7 @@ public Task UpdateBalancesAsync(IDbConnection con, IDbTransaction tx, PoolConfig
 
                 if (cutOffCount > 0)
                 {
-                    //LogObsoleteShares(poolConfig, block, shareCutOffDate.Value);
+                    LogObsoleteShares(poolConfig, block, shareCutOffDate.Value);
 
                     logger.Info(() => $"Deleting {cutOffCount} obsolete shares before {shareCutOffDate.Value}");
                     shareRepo.DeletePoolSharesBeforeCreated(con, tx, poolConfig.Id, shareCutOffDate.Value);
@@ -144,10 +144,12 @@ private void LogObsoleteShares(PoolConfig poolConfig, Block block, DateTime valu
                 var blockPage = shareReadFaultPolicy.Execute(() =>
                     cf.Run(con => shareRepo.ReadSharesBeforeCreated(con, poolConfig.Id, before, false, pageSize)));
 
+                if (blockPage.Length == 0)
+                    break;
+
                 currentPage++;
-                var start = blockPage.Length > 0 ? blockPage.Length - 1 : -1;
 
-                for (var i = start; i >= 0; i--)
+                for (var i = 0;i < blockPage.Length; i++)
                 {
                     var share = blockPage[i];
 
@@ -166,18 +168,18 @@ private void LogObsoleteShares(PoolConfig poolConfig, Block block, DateTime valu
                 if (blockPage.Length < pageSize)
                     break;
 
-                before = blockPage[0].Created;
+                before = blockPage[blockPage.Length - 1].Created;
             }
 
             if (shares.Keys.Count > 0)
             {
                 // sort addresses by shares
                 var addressesByShares = shares.Keys.OrderByDescending(x => shares[x]);
 
-                // compute summary
-                var summary = string.Join("\n", addressesByShares.Select(address => $"{address} = {FormatUtil.FormatQuantity(shares[address])} ({shares[address]}) shares"));
+                logger.Info(() => $"{FormatUtil.FormatQuantity(shares.Values.Sum())} ({shares.Values.Sum()}) obsolete shares total for block {block.BlockHeight}");
 
-                logger.Info(() => $"{FormatUtil.FormatQuantity(shares.Values.Sum())} ({shares.Values.Sum()}) obsolete shares:\n" + summary);
+                foreach (var address in addressesByShares)
+                    logger.Info(() => $"{address} = {FormatUtil.FormatQuantity(shares[address])} ({shares[address]}) shares for block {block.BlockHeight}");
             }
         }
 
@@ -209,9 +211,7 @@ private void LogObsoleteShares(PoolConfig poolConfig, Block block, DateTime valu
                 inclusive = false;
                 currentPage++;
 
-                var start = blockPage.Length > 0 ? blockPage.Length - 1 : -1;
-
-                for (var i = start; !done && i >= 0; i--)
+                for (var i = 0; !done && i < blockPage.Length; i++)
                 {
                     var share = blockPage[i];
 
@@ -258,7 +258,7 @@ private void LogObsoleteShares(PoolConfig poolConfig, Block block, DateTime valu
                 if (blockPage.Length < pageSize)
                     break;
 
-                before = blockPage[0].Created;
+                before = blockPage[blockPage.Length - 1].Created;
             }
 
             logger.Info(() => $"Balance-calculation for pool {poolConfig.Id}, block {block.BlockHeight} completed with accumulated score {accumulatedScore:0.####} ({(accumulatedScore / window) * 100:0.#}%)");