Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting configured_hz from info server #944

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

justinmir
Copy link
Contributor

When the dynamic-hz configuration option is in-use (Redis 6+), Redis will include configured_hz in the output of info server. The hz that is currently configured can impact Redis CPU utilization.

This introduces exporting the server's current configured_hz value.

When the `dynamic-hz` configuration option is in-use (Redis 6+), Redis
will include `configured_hz` in the output of `info server`. The `hz`
that is currently configured can impact Redis CPU utilization.

This introduces exporting the server's current `configured_hz` value.
@coveralls
Copy link

coveralls commented Sep 6, 2024

Pull Request Test Coverage Report for Build 10813968541

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 84.114%

Totals Coverage Status
Change from base Build 10813931276: 0.05%
Covered Lines: 2012
Relevant Lines: 2392

💛 - Coveralls

@oliver006
Copy link
Owner

Looks good.
configured_hz - question: what unit is that in? Can we add it to the metric name? Also, should you expose hz as well or is that already there?

@justinmir
Copy link
Contributor Author

configured_hz - question: what unit is that in? Can we add it to the metric name? Also, should you expose hz as well or is that already there?

The unit in this case is actually just hz which is the unit of frequency: 1 hz == once per second.

@justinmir
Copy link
Contributor Author

Updated to add hz since it wasn't included

@oliver006
Copy link
Owner

PR looks good!

Can you please rebase and pull in the new changes that run the tests in Github Actions?

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.25%. Comparing base (262770b) to head (635cfc2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #944      +/-   ##
==========================================
+ Coverage   80.19%   80.25%   +0.06%     
==========================================
  Files          17       17              
  Lines        1974     1980       +6     
==========================================
+ Hits         1583     1589       +6     
  Misses        306      306              
  Partials       85       85              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliver006 oliver006 merged commit 82cc804 into oliver006:master Sep 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants