Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add graceful shutdown #867

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Add graceful shutdown #867

merged 7 commits into from
Jan 25, 2024

Conversation

wanghaowei0107
Copy link
Contributor

@wanghaowei0107 wanghaowei0107 commented Jan 5, 2024 •
edited
Loading

@coveralls
Copy link

coveralls commented Jan 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 261

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 91.963%
Totals Coverage Status
Change from base Build 247: -0.1%
Covered Lines: 1968
Relevant Lines: 2140
💛 - Coveralls

@oliver006
Copy link
Owner

Thanks for looking into this!
How does this fix the issue?
The listen call in line 225/227 should block so I don't think we ever down to where you catch the signal.

@wanghaowei0107 wanghaowei0107 reopened this Jan 9, 2024
@wanghaowei0107 wanghaowei0107 changed the title Add graceful shutdown. Add graceful shutdown Jan 9, 2024
@oliver006
Copy link
Owner

Thanks for updating this PR, this looks a lot better.
Did you have a chance to test it? Does it work?

@wanghaowei0107
Copy link
Contributor Author

wanghaowei0107 commented Jan 15, 2024 •
edited
Loading

Yes,I did test in local.It's work.
By the way, Can you tell me why drone/pr check is always pending on first step?
I don't know how to pass this check.
Thank you.
微信图片_20240115101136

oliver006
oliver006 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.
This looks good - please one last change for the message that is printed and then we should be good to go.

main.go Outdated Show resolved Hide resolved
oliver006
oliver006 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the PR!

@wanghaowei0107
Copy link
Contributor Author

So when will this feature be released?

@oliver006 oliver006 merged commit 27e114b into oliver006:master Jan 25, 2024
4 of 5 checks passed
@oliver006 oliver006 mentioned this pull request Jan 25, 2024
Closed
@oliver006
Copy link
Owner

Released as https://github.com/oliver006/redis_exporter/releases/tag/v1.57.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver006 oliver006 oliver006 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wanghaowei0107 @coveralls @oliver006