Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading TLS system certificate store #858

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

stanhu
Copy link
Contributor

@stanhu stanhu commented Dec 12, 2023

Previously a server CA had to be specified for TLS work, even if the system store trusted the cert already.

@coveralls
Copy link

coveralls commented Dec 12, 2023

Pull Request Test Coverage Report for Build 226

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 91.942%

Changes Missing Coverage Covered Lines Changed/Added Lines %
exporter/tls.go 5 7 71.43%
Totals Coverage Status
Change from base Build 221: -0.07%
Covered Lines: 1951
Relevant Lines: 2122

💛 - Coveralls

Previously a server CA had to be specified for TLS work, even if the
system store trusted the cert already.
Copy link
Owner

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@oliver006 oliver006 merged commit 357e7ac into oliver006:master Dec 20, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants