Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only enable histograms for Redis 7+ #847

Closed
wants to merge 1 commit into from

Conversation

grafanalf
Copy link

relates-to: #784

@coveralls
Copy link

Pull Request Test Coverage Report for Build 219

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 91.785%

Files with Coverage Reduction New Missed Lines %
exporter/latency.go 5 91.3%
Totals Coverage Status
Change from base Build 218: -0.2%
Covered Lines: 1944
Relevant Lines: 2118

💛 - Coveralls

@oliver006
Copy link
Owner

Thanks for the PR!

I think I mentioned in #784 that I prefer to not make the exporter version-aware, esp if it's not needed to enable certain functionality.
The log-line should show up only once - is it that big of an issue?

@oliver006 oliver006 closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants