Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node role metric #819

Closed
wants to merge 5 commits into from

Conversation

snoojen
Copy link

@snoojen snoojen commented Jul 25, 2023

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 165

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.538%

Totals Coverage Status
Change from base Build 164: 0.02%
Covered Lines: 1947
Relevant Lines: 2104

💛 - Coveralls

@oliver006
Copy link
Owner

instance_info already exports role - how is this different?

See here:

redis_instance_info{app="redis", instance="10.42.0.246:9121", job="kubernetes-pods", maxmemory_policy="noeviction", 
namespace="redis", os="Linux 5.4.0-153-generic x86_64", pod="redis-5d7898859b-6jnq9", 
pod_template_hash="5d7898859b", process_id="1", redis_build_id="3a1fe9d08e5ebeb", redis_mode="standalone", 
redis_version="6.2.12", role="master", run_id="9a291d29d3ceea449633316f29712616ecc11a07", tcp_port="6379"}

@snoojen
Copy link
Author

snoojen commented Jul 26, 2023

Thanks for the response! That fits the need we have for now - I'll close the PR.

@snoojen snoojen closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants