Skip to content

Commit

Permalink
chore(deps): update dependency cordova-android to v13 (#102)
Browse files Browse the repository at this point in the history
* chore(deps): update dependency cordova-android to v13

* chore: BuildConfig.DEBUG is comment out

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hiroyuki Okada <[email protected]>
  • Loading branch information
renovate[bot] and okhiroyuki authored Jul 7, 2024
1 parent 77c03e4 commit 267bf0f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@red-mobile/nodejs-mobile-cordova",
"version": "3.4.0",
"version": "3.4.1",
"description": "Node.js for Mobile Apps Cordova plugin",
"cordova": {
"id": "@red-mobile/nodejs-mobile-cordova",
Expand Down
2 changes: 1 addition & 1 deletion plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
id="@red-mobile/nodejs-mobile-cordova"
version="3.4.0">
version="3.4.1">

<name>Node.js Mobile</name>
<description>Node.js for Mobile Apps Cordova Plugin</description>
Expand Down
20 changes: 10 additions & 10 deletions src/android/java/com/janeasystems/cdvnodejsmobile/NodeJS.java
Original file line number Diff line number Diff line change
Expand Up @@ -582,16 +582,16 @@ private static void deleteFolderRecursively(File file) {
}

private static boolean getOptionRedirectOutputToLogcat(final JSONObject startOptions) {
if (BuildConfig.DEBUG) {
if (startOptions.names() != null) {
for (int i = 0; i < startOptions.names().length(); i++) {
try {
Log.d(LOGTAG, "Start engine option: " + startOptions.names().getString(i));
} catch (JSONException e) {
}
}
}
}
// if (BuildConfig.DEBUG) {
// if (startOptions.names() != null) {
// for (int i = 0; i < startOptions.names().length(); i++) {
// try {
// Log.d(LOGTAG, "Start engine option: " + startOptions.names().getString(i));
// } catch (JSONException e) {
// }
// }
// }
// }

final String OPTION_NAME = "redirectOutputToLogcat";
boolean result = true;
Expand Down
2 changes: 1 addition & 1 deletion testapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
},
"devDependencies": {
"@red-mobile/nodejs-mobile-cordova": "file:temp-module-copy",
"cordova-android": "12.0.1",
"cordova-android": "13.0.0",
"nodejs-mobile-cordova-tests": "file:temp-module-copy/tests"
}
}

0 comments on commit 267bf0f

Please sign in to comment.