Implement shortcuts

[guergana]

• fixes Implement shortcuts #606

TODO : test for Mac

[cloudflare-workers-and-pages]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	219b01f
Status:	✅  Deploy successful!
Preview URL:	https://edaee196.opendataeditor.pages.dev
Branch Preview URL:	https://606-shortcuts.opendataeditor.pages.dev

View logs

[romicolman]

Let's implement the rest and omit the Ctrl+Q for now

[guergana]

Let's implement the rest and omit the Ctrl+Q for now

Hello @romicolman I just discovered many shortcuts that were already implemented in the app before this change. I think this is not desired. For example: ctrl + k brings up the Publish dialog.

You can see the shortcuts that are already implemented in this file: https://github.com/okfn/opendataeditor/blob/main/client/components/Parts/Bars/Action.tsx#L40

and this https://github.com/okfn/opendataeditor/blob/main/client/components/Parts/Bars/Menu.tsx#L56

There is one here too: https://github.com/okfn/opendataeditor/blob/main/client/components/Parts/Chips/Create.tsx#L13

I guess we need to remove these ones as well as part of this task?

[romicolman]

Hi @guergana! Thank you! Let's remove all and just keep the ones that are in the ticket, except from Ctrl + Q

[romicolman]

Hi! I have just tested the implementation. Apart from ENTER, ESC, none of the shortcuts work on Mac. Can we check if we need to define different parameters for this OS?

[romicolman]

@guergana just in case this is useful, here are some Mac shortcuts:https://support.apple.com/en-us/102650

[romicolman]

Changes on Mac are not working (I'll create a new ticket to address this) but please, implement this so we can quickly merge this to the main code for Windows and Linux users.