Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2517 #2519

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Closes #2517 #2519

merged 1 commit into from
Jan 17, 2025

Conversation

corrideat
Copy link
Member

No description provided.

@corrideat corrideat self-assigned this Jan 17, 2025
@corrideat corrideat requested a review from taoeffect January 17, 2025 21:30
taoeffect
taoeffect requested changes Jan 17, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @corrideat! Surprisingly this seemed to fix it, as long as there is only one tab open. One RFC:

frontend/model/database.js Outdated Show resolved Hide resolved
@corrideat corrideat force-pushed the 2517-firefox-service-worker-issue branch from 659f104 to cd87145 Compare January 17, 2025 21:48
@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025

group-income    Run #3745

Run Properties:  status check passed Passed #3745  •  git commit 9c3199e329 ℹ️: Merge cd871452b954565e3e117ab62c7f0dad70462bd9 into 1ee4525a8402f8cfa8af5c06a79a...
Project group-income
Branch Review 2517-firefox-service-worker-issue
Run status status check passed Passed #3745
Run duration 10m 43s
Commit git commit 9c3199e329 ℹ️: Merge cd871452b954565e3e117ab62c7f0dad70462bd9 into 1ee4525a8402f8cfa8af5c06a79a...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 112
View all changes introduced in this branch ↗︎

@corrideat corrideat requested a review from taoeffect January 17, 2025 22:10
taoeffect
taoeffect approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taoeffect taoeffect merged commit f981369 into master Jan 17, 2025
4 checks passed
@taoeffect taoeffect deleted the 2517-firefox-service-worker-issue branch January 17, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@corrideat corrideat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corrideat @taoeffect