Qa/128 보낸 봉투 검색 시 검색결과와 관계 없는 봉투가 보이는 현상 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinukeu
approved these changes
Jun 3, 2024
| @@ -52,37 +54,41 @@ class SentEnvelopeSearchViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| fun getEnvelopeList(search: String) = viewModelScope.launch { | |||
| if (search.isEmpty()) return@launch | |||
There was a problem hiding this comment.
p5) 요 부분 제외하구 ... 아래 async 사용한건 로직상 동일해보이는데 맞나요!?
async + await 사용해서 응답속도가 더 빨라졌겠군요~
There was a problem hiding this comment.
넵~ 로직 자체는 동일합니다~!
case1) 숫자X 검색어로 친구가 검색됨 -> 친구 id로 검색
case2) 숫자O, 친구 검색 결과 X -> 금액으로만 검색
case3) 숫자O, 친구 검색 결과 O (친구 이름에 숫자가 들어가는 경우) -> 친구 id, 금액으로 모두 검색
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 Key changes
✅ To Reviewers
📸 스크린샷