Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: print output instead of executing #25

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevingriffin
Copy link

This pull requests adds a -p/--print flag to fenv which allows for outputting the set commands generated instead of executing them.

The motivation for this way to move the calls to fenv from shell start time to configuration generation time in nix.

It's a bit expensive to call fenv on every shell launch, but it would be possible to translate the bash environment file once and cache the result as native fish set commands.

@kevingriffin
Copy link
Author

It occurs to me after some more testing that it's not valid to do interpolation eagerly when computing for use later, so some sort of approach where keys with values that have interpolation in them needs to be implemented in order to insert a transformed interpolation call later. I'll see if I can get that in.

@kevingriffin kevingriffin marked this pull request as draft December 27, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant