Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dst_N_autocreation ZFS properties #637

Merged
merged 11 commits into from
May 2, 2024

Conversation

jimklimov
Copy link
Contributor

@jimklimov jimklimov commented Feb 8, 2024

Builds on top of #636 ideas and is a step towards #503 hopefully.

At this time some optimization is possible: to only get dataset properties for the source tree once and walk the resulting array of hashes, instead of requesting props many times (once per child dataset as it does here, not unlike the oracleMode which trades one-by-one zfs commands handling vs. memory footprint of querying large chunks of names/properties on very populated ZFS trees). Still, as an MVP, this code already is functional (checked locally).

Note lower-case "c" in autoCreation - dictated by ZFS property name constraints

Signed-off-by: Jim Klimov <[email protected]>
Copy link

github-actions bot commented Feb 8, 2024

@check-spelling-bot Report jimklimov/znapzend: autoCreation-dstN into -> oetiker/znapzend: 62394b2

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

autocreation

Previously acknowledged words that are now absent aix Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz CBuilder cpanfile cpanm cpanmin CPANSNAPV crt Cwd cygwin DBD DESTDIR distdir DTDs endif EXTRADIST Fcntl forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup JBERGER LEONT lpr Mkbootstrap nobase notest nroff ODBC Pipely RCAPUTO SUBDIRS svcdir troff unicode utf VOS vroff xargs 🫥
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the https://github.com/oetiker/znapzend repository
on the master branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/oetiker/znapzend/actions/runs/7836088364/attempts/1'
Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary

This includes both expected items (656) from .github/workflows//spelling/expect.txt and unrecognized words (1)

Dictionary Entries Covers Uniquely
cspell:software-terms/dict/softwareTerms.txt 1288 81 17
cspell:php/dict/php.txt 1689 58 6
cspell:python/src/python/python-lib.txt 2417 53 6
cspell:node/dict/node.txt 891 56 5
cspell:filetypes/filetypes.txt 264 19 4

Consider adding them (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:software-terms/dict/softwareTerms.txt
          cspell:php/dict/php.txt
          cspell:python/src/python/python-lib.txt
          cspell:node/dict/node.txt
          cspell:filetypes/filetypes.txt

To stop checking additional dictionaries, add (in .github/workflows/spelling.yml):

check_extra_dictionaries: ''

oetiker
oetiker previously approved these changes Apr 25, 2024
@oetiker
Copy link
Owner

oetiker commented Apr 26, 2024

@jimklimov the last open pr ... could you have a look at the conflicts?

@jimklimov
Copy link
Contributor Author

Cool! :) Yes, thanks. Were the others squashed too, I guess (should have otherwise shared part of history in commit chains IIRC)?

@jimklimov jimklimov dismissed oetiker’s stale review April 26, 2024 11:48

The merge-base changed after approval.

@jimklimov
Copy link
Contributor Author

jimklimov commented Apr 26, 2024

PR source updated to match new master (and effectively to confirm applying its original changes over it).

@oetiker
Copy link
Owner

oetiker commented May 2, 2024

not squashed :)

@oetiker oetiker merged commit b02cfff into oetiker:master May 2, 2024
4 checks passed
@jimklimov jimklimov deleted the autoCreation-dstN branch May 8, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants