-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dst_N_autocreation
ZFS properties
#637
Conversation
Note lower-case "c" in autoCreation - dictated by ZFS property name constraints Signed-off-by: Jim Klimov <[email protected]>
@check-spelling-bot Report jimklimov/znapzend: autoCreation-dstN into -> oetiker/znapzend: 62394b2🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (1)autocreation Previously acknowledged words that are now absentaix Balert Bcreate Bdebug Bdelete Bedit Berr Bexport Bimport Binfo Bnoaction Bnot Bpidfile Bpost Bpre Bsyslog Bwarning Bzfs Bznapzend Bznapzendzetup Bznapzendztatz CBuilder cpanfile cpanm cpanmin CPANSNAPV crt Cwd cygwin DBD DESTDIR distdir DTDs endif EXTRADIST Fcntl forkcall Icommand Icommon Icreate Idataset Idestroy Idocuments Iexport Ifacility Ifeature Ifilepath Ihome Ilimited imandir Inumber Ioptions Ipath Ipictures Irecursive Isend Iskip Isnapshots Isnapsuffix Isources Itank Ithirdparty Itimeout Iusbbackup Iuser Ivalue Iznapzendzetup JBERGER LEONT lpr Mkbootstrap nobase notest nroff ODBC Pipely RCAPUTO SUBDIRS svcdir troff unicode utf VOS vroff xargs 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the https://github.com/oetiker/znapzend repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/oetiker/znapzend/actions/runs/7836088364/attempts/1' Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (656) from .github/workflows//spelling/expect.txt and unrecognized words (1)
Consider adding them (in with:
extra_dictionaries:
cspell:software-terms/dict/softwareTerms.txt
cspell:php/dict/php.txt
cspell:python/src/python/python-lib.txt
cspell:node/dict/node.txt
cspell:filetypes/filetypes.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' |
…operty Signed-off-by: Jim Klimov <[email protected]>
3d5a636
to
570bd7a
Compare
…utocreation is disabled Signed-off-by: Jim Klimov <[email protected]>
…ve the dataset and know we do not intend to auto-create it Signed-off-by: Jim Klimov <[email protected]>
@jimklimov the last open pr ... could you have a look at the conflicts? |
Cool! :) Yes, thanks. Were the others squashed too, I guess (should have otherwise shared part of history in commit chains IIRC)? |
The merge-base changed after approval.
PR source updated to match new master (and effectively to confirm applying its original changes over it). |
not squashed :) |
Builds on top of #636 ideas and is a step towards #503 hopefully.
At this time some optimization is possible: to only get dataset properties for the source tree once and walk the resulting array of hashes, instead of requesting props many times (once per child dataset as it does here, not unlike the
oracleMode
which trades one-by-onezfs
commands handling vs. memory footprint of querying large chunks of names/properties on very populated ZFS trees). Still, as an MVP, this code already is functional (checked locally).