Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steam Turbine with wet expansion #602
base: dev
Are you sure you want to change the base?
Steam Turbine with wet expansion #602
Changes from 9 commits
421df3e
7646dab
cf15c32
fa7528e
0099b82
39f8be2
9c479a7
5603db9
3edfeba
e4cf531
9c0ef75
3a930e1
cc05a7e
88c249b
164eb12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes two expansion sections, right? The first one by finding the pressure, where the expansion enters the dome, then the second one for the rest: The first one applies dry isentropic efficiency, the second one with the correction term?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some benchmark with brentq vs. newton algorithm:
scipy
'sbrentq
is faster by ~factor 3. I will have to look into the fluid property module (and in all other places), where the newton is utilized and see ifbrentq
generally performs better :D.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, the "wetness" correction is only applied in the two-phase region, for single phase vapour no correction is applied.
So if the vapour is superheated, we first have to find the point where the expansion enters the vapour dome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding Brentq, I performs particularly well if the solution is bracketed, or you know that the function is not necessarily computable for all conditions.