Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the destroy method. #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

david04
Copy link

@david04 david04 commented May 9, 2014

No description provided.

@azr
Copy link

azr commented May 24, 2014

The most advanced/active repo of this libs seems to be here : https://github.com/samuelcole/imgareaselect

@azr
Copy link

azr commented May 24, 2014

In fact no, his version of master is broken

@IRun26Point2
Copy link

I may be mistaken, but the source on odyniec's website seems to be ver 0.9.10, and I'm not sure if there are other forks that are out there that have a solid base for production code. I spent quite some time trying to integrate the multi select fork, but there were just too many shortcuts taken in the original design to get it to work durably. Polluting the DOM has been discussed, the use of global variables and side effects make it difficult to extend as assumptions get broken arbitrarily. For example, the notion of delete doesn't exist, it hides instead, but the multiselect fork deleted except for the last one, making composing with any kind of binding layer too complicated to rely on. Is anyone interested in spinning up an effort to refactor the base and add some of the top feature requests, maybe adding a binding layer, adding it to definitelytyped.com, etc?

@azr
Copy link

azr commented May 25, 2014

I went using Jcrop, much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants