Use a common Makefile, Build automation #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The makefiles were exact duplicates, use a common makefile. Add a common makefile in the common directory and include it in the other makefiles. Signed-off-by: Rick Wertenbroek <[email protected]>
Compile with the static .a libraries only when compiling the static exe. Search for the .a static libraries in system automatically and warn if they are not found. Clean the rules to use the library paths found. Add dynamic libraries for boost and htslib when linking the normal exe (the non static one). Signed-off-by: Rick Wertenbroek <[email protected]>
This is a script for automated build of SHAPEIT5 and XCFTools on a GitHub runner. It will run on Ubuntu 20.04, download all dependencies, clone the SHAPEIT5 repository, init submodules, build SHAPEIT5 and XCFTools. Signed-off-by: Rick Wertenbroek <[email protected]>
Add a build badge on the main README to show if the project builds Add a build badge to to show if the documentation pages build Signed-off-by: Rick Wertenbroek <[email protected]>
|
The Build system shows a failure to build XCFTools, this is normal, it is because the XCFTools changes have not yet been merged and the submodule was not yet updated in SHAPEIT5. (The old XCFTools makefile is missing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Olivier, Simone,
Here is a pull request for 4 patches to SHAPEIT5. They do the following :
commondirectory and include it instead of duplicating the Makefiles.After this pull request, it would be nice to update the XCFTools submodule to the version of XCFTools after my pull request on XCFTools, all builds should pass.
Best regards,
Rick