Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend free up space and propery check token expiration #716

Merged
merged 10 commits into from
Oct 15, 2024

Conversation

burnout87
Copy link
Collaborator

No description provided.

@burnout87 burnout87 linked an issue Oct 9, 2024 that may be closed by this pull request
@burnout87
Copy link
Collaborator Author

I noticed that with a11f62d from #496 , the token is expected to be already decoded when read from the analysis_parameters.json file. Which is obviously a wrong assumption. So with this PR this will also be fixed

@burnout87 burnout87 self-assigned this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (a4068ea) to head (9b47089).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
cdci_data_analysis/pytest_fixtures.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   61.97%   62.05%   +0.08%     
==========================================
  Files          50       50              
  Lines        9115     9138      +23     
==========================================
+ Hits         5649     5671      +22     
- Misses       3466     3467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87
Copy link
Collaborator Author

The free-up-space functionality has been extended to delete the no longer needed lock files: in the case of no more scratch_dir available for a certain job_id, the correspondent lock file will be deleted.

What do you think?

@burnout87 burnout87 changed the title Extend free up space Extend free up space and propery check token expiration Oct 14, 2024
@burnout87 burnout87 merged commit f3e0e20 into master Oct 15, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extending free-up-space with the deletion of the lock files
3 participants