Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check CurrentBuild instead of DisplayVersion #178

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Check CurrentBuild instead of DisplayVersion #178

merged 1 commit into from
Nov 29, 2023

Conversation

mtelvers
Copy link
Member

DisplayVersion does not exist in Windows 2019 or earlier. Check CurrentBuild instead.

In the match clause, I have listed all versions of Windows where a tag exists in the Microsoft registry. The default value of ltsc2022 should be ok until the next version of Windows Server.

References:

@mtelvers mtelvers requested a review from MisterDA November 29, 2023 11:21
MisterDA
MisterDA approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@MisterDA MisterDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I fully trust you on this :-)

@mtelvers mtelvers merged commit 2d0af3d into ocurrent:master Nov 29, 2023
4 of 5 checks passed
@mtelvers mtelvers deleted the CurrentBuild branch November 29, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterDA MisterDA MisterDA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtelvers @MisterDA