Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): updates all node versions in workflows to v18 #576

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

nickfloyd
Copy link
Contributor

While this change is not technically required as part of our efforts to drop support for NodeJS v14, v16 - this does help to get all of our packages and tooling in sync with a consistent node version.

Part of: octokit/octokit.js#2486


Behavior

Before the change?

  • We were using node v16 in our test workflow

After the change?

  • We are now using v18

Copy link
Member

@wolfy1339 wolfy1339 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are dropping node v16, you can go with lockfile v3

@nickfloyd
Copy link
Contributor Author

nickfloyd commented Jun 26, 2023

Since we are dropping node v16, you can go with lockfile v3

100% solid call... I'll make the change.

@nickfloyd nickfloyd requested a review from wolfy1339 June 26, 2023 19:31
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@nickfloyd nickfloyd changed the title updates all node versions in workflows to v18 build(deps): updates all node versions in workflows to v18 Jun 26, 2023
@nickfloyd nickfloyd merged commit b2751f6 into main Jun 26, 2023
@nickfloyd nickfloyd deleted the update-node-in-workflows branch June 26, 2023 20:28
Copy link
Contributor

🎉 This PR is included in version 22.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants