src/oping.c: always use "%s"-style format for printf()-style functions #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ncuses-6.3` added printf-style function attributes and now makes
it easier to catch cases when user input is used in palce of format
string when built with CFLAGS=-Werror=format-security:
oping.c:1265:41: error: format not a string literal and no format arguments [-Werror=format-security]
1265 | hist_symbols_utf8[index]);
| ^~~~~~~~~~~~~~~~~
Let's wrap all the missing places with "%s" format.
hnyman
added a commit
to hnyman/packages
that referenced
this pull request
Mar 20, 2022
Fix compilation with ncurses 6.3 by adjusting the printf format strings. Apparently ncurses 6.3 introduced some new formatting tweaks that broke things. Fixes openwrt#18110 Reference to: * octo/liboping#62 * octo/liboping#61 * https://salsa.debian.org/debian/liboping/-/blob/debian/debian/patches/fix_HOST_PRINTF_format_string.patch Signed-off-by: Hannu Nyman <[email protected]>
hnyman
added a commit
to hnyman/packages
that referenced
this pull request
Mar 20, 2022
Fix compilation with ncurses 6.3 by adjusting the printf format strings. Apparently ncurses 6.3 introduced some new formatting tweaks that broke things. Fixes openwrt#18110 Reference to: * octo/liboping#62 * octo/liboping#61 * https://salsa.debian.org/debian/liboping/-/blob/debian/debian/patches/fix_HOST_PRINTF_format_string.patch Signed-off-by: Hannu Nyman <[email protected]> (cherry picked from commit cb4d8cc)
Beginner-Go
pushed a commit
to coolsnowwolf/packages
that referenced
this pull request
Mar 21, 2022
Fix compilation with ncurses 6.3 by adjusting the printf format strings. Apparently ncurses 6.3 introduced some new formatting tweaks that broke things. Fixes #18110 Reference to: * octo/liboping#62 * octo/liboping#61 * https://salsa.debian.org/debian/liboping/-/blob/debian/debian/patches/fix_HOST_PRINTF_format_string.patch Signed-off-by: Hannu Nyman <[email protected]>
1715173329
pushed a commit
to immortalwrt/packages
that referenced
this pull request
Mar 25, 2022
Fix compilation with ncurses 6.3 by adjusting the printf format strings. Apparently ncurses 6.3 introduced some new formatting tweaks that broke things. Fixes #18110 Reference to: * octo/liboping#62 * octo/liboping#61 * https://salsa.debian.org/debian/liboping/-/blob/debian/debian/patches/fix_HOST_PRINTF_format_string.patch Signed-off-by: Hannu Nyman <[email protected]> (cherry picked from commit cb4d8cc)
|
This works for me.. @octo Can it be merged? |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Aug 12, 2024
Pulled from octo/liboping#61 PR: 280780 Approved by: garga Sponsored by: Rubicon Communications, LLC ("Netgate")
nanorkyo
pushed a commit
to nanorkyo/freebsd-ports
that referenced
this pull request
Aug 21, 2024
Pulled from octo/liboping#61 PR: 280780 Approved by: garga Sponsored by: Rubicon Communications, LLC ("Netgate")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ncuses-6.3added printf-style function attributes and now makesit easier to catch cases when user input is used in palce of format
string when built with CFLAGS=-Werror=format-security:
Let's wrap all the missing places with "%s" format.