Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokensource library #449

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add tokensource library #449

wants to merge 1 commit into from

Conversation

wlynch
Copy link
Collaborator

@wlynch wlynch commented Aug 12, 2024

Adds library to make it easy to create a oauth2.TokenSource for use with GitHub clients.

@wlynch wlynch requested a review from imjasonh August 12, 2024 21:34
@imjasonh
Copy link
Contributor

Actually I'd probably not use a library that pulls in k8s deps just to get this in tf-common. Plus it depends on tf-common itself 😆

Any chance we could make an octo-sts/client repo? 🤷

@wlynch
Copy link
Collaborator Author

wlynch commented Aug 12, 2024

I'm for that.

@mattmoor objections?

@mattmoor
Copy link
Member

I'm missing something, what's the K8s dep?

@wlynch
Copy link
Collaborator Author

wlynch commented Aug 12, 2024

I think jason is referring to the deps in go.mod for the server components. IIIUC even though the Go tool is smart enough to not include them in produced binaries if they're unused, they'll still show up in go.mod of dependencies as indirect and you'll need to dependabot bump them regularly.

@mattmoor
Copy link
Member

I see a single line in the entire repo using the API machinery sets which could simply use something else, and I am not sure that sigs.k8s.io/yaml is anything to be worried about (I believe it's a fork of another yaml package to support json annotations, so I think it's well scoped/contained).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants