Don't leak channels. #1601
Open
Don't leak channels. #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the required ppx_expect changes? |
|
Merged
|
Hi, you should be able to merge this after updating ppx_expect to v0.17.1. (see ocaml/opam-repository#26695) |
@dkalinichenko-js, I probably won't be able to upgrade to v0.17.1 because it will probably still be broken on windows. See janestreet/ppx_expect#57 |
|
I see. I'll submit another release of |
|
@dkalinichenko-js, the new blocker is that the new release of ppx_expect is not available for ocaml 4.14, preventing us to run our expect_tests with OCaml 4.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #1578 and #1577.
This PR requires ppx_expect and alcotest to be changed.
Because the jsoo codebase rely on ppx_expect for its tests, we have a Chicken-and-egg situation.
I can make a minor release of jsoo that would include new runtime function while keeping the existing storage mechanism.
Once jsoo is released, ppx_expect can rely on the new runtime functions.
After ppx_expect is released, we can merge this PR.
@tkluck-janestreet, how does that sound ?