Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OCaml trunk #1487

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ jobs:
- "4.13"
- "5.0"
- "5.1"
- "5.2"
skip-test:
- true
skip-doc:
Expand Down Expand Up @@ -53,7 +54,7 @@ jobs:
skip-test: false
skip-doc: true
- os: ubuntu-latest
ocaml-compiler: "5.2"
ocaml-compiler: "ocaml-variants.5.3.0~alpha1"
skip-effects: false
skip-test: false
skip-doc: false
Expand All @@ -64,12 +65,12 @@ jobs:
skip-test: true # the `time_now.0.17` package is pulled and doesn't work in 32 bits :(
skip-doc: true
- os: macos-latest
ocaml-compiler: "5.2"
ocaml-compiler: "ocaml-variants.5.3.0~alpha1"
skip-effects: true
skip-test: false
skip-doc: true
- os: windows-latest
ocaml-compiler: "5.2"
ocaml-compiler: "ocaml-variants.5.3.0~alpha1"
skip-effects: false
skip-test: false
skip-doc: true
Expand Down Expand Up @@ -115,6 +116,13 @@ jobs:
- run: opam install conf-pkg-config
if: runner.os == 'Windows'

- run: opam pin add ppxlib --dev --no-action
if: ${{ matrix.ocaml-compiler == 'ocaml-variants.5.3.0~alpha1' }}
- run: opam pin add ppxlib_jane git+https://github.com/hhugo/ppxlib_jane.git#trunk-support-503 --no-action
if: ${{ matrix.ocaml-compiler == 'ocaml-variants.5.3.0~alpha1' }}

- run: opam pin add ./ --no-action

- run: opam install . --best-effort
if: ${{ matrix.skip-test }}

Expand Down
2 changes: 0 additions & 2 deletions compiler/tests-check-prim/main.output5
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Missing
From main.bc:
caml_alloc_dummy_function
caml_continuation_use
caml_drop_continuation
caml_dynlink_add_primitive
caml_dynlink_close_lib
caml_dynlink_get_current_libs
Expand Down Expand Up @@ -172,7 +171,6 @@ caml_spacetime_only_works_for_native_code
caml_sys_const_naked_pointers_checked

From +toplevel.js:
caml_get_section_table
caml_static_alloc
caml_static_free
caml_terminfo_backup
Expand Down
1 change: 1 addition & 0 deletions compiler/tests-check-prim/unix-unix.output
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ Unused
-------

From +array.js:
caml_array_create_float
caml_check_bound

From +bigarray.js:
Expand Down
2 changes: 0 additions & 2 deletions compiler/tests-check-prim/unix-unix.output5
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Missing
From unix.bc:
caml_alloc_dummy_function
caml_continuation_use
caml_drop_continuation
caml_dynlink_add_primitive
caml_dynlink_close_lib
caml_dynlink_get_current_libs
Expand Down Expand Up @@ -283,7 +282,6 @@ caml_spacetime_only_works_for_native_code
caml_sys_const_naked_pointers_checked

From +toplevel.js:
caml_get_section_table
caml_static_alloc
caml_static_free
caml_terminfo_backup
Expand Down
1 change: 1 addition & 0 deletions compiler/tests-check-prim/unix-win32.output
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ Unused
-------

From +array.js:
caml_array_create_float
caml_check_bound

From +bigarray.js:
Expand Down
6 changes: 3 additions & 3 deletions compiler/tests-full/dune
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(rule
(targets stdlib.cma.js)
(enabled_if
(= %{ocaml_version} "5.2.0"))
(> %{ocaml_version} "5.2.0"))
(action
(run
%{bin:js_of_ocaml}
Expand All @@ -14,7 +14,7 @@
(rule
(targets stdlib.cma.output.js)
(enabled_if
(= %{ocaml_version} "5.2.0"))
(> %{ocaml_version} "5.2.0"))
(action
(with-stdout-to
%{targets}
Expand All @@ -23,7 +23,7 @@
(rule
(alias runtest)
(enabled_if
(= %{ocaml_version} "5.2.0"))
(> %{ocaml_version} "5.2.0"))
(action
(diff stdlib.cma.expected.js stdlib.cma.output.js)))

Expand Down
Loading
Loading