Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort list of required attributes in JSON schema #106

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

lukas-krecan
Copy link
Contributor

We are fetching the JSON schema from OCSF server and committing it to a repo. The order of the required fields changes randomly, generating unnecessarily large diffs.

We are fetching the JSON schema from OCSF server and committing it to
a repo. The order of the required fields changes randomly, generating 
unnecessarily large diffs.
@mikeradka mikeradka assigned mikeradka and unassigned mikeradka Aug 16, 2024
@mikeradka mikeradka added the enhancement New feature or request label Aug 16, 2024
@mikeradka
Copy link
Contributor

Nice catch. I think this makes sense to do and looks good to me, but would also like @floydtree and @rmouritzen-splunk to take a look. Also along with this the server version should be updated in mix.exs following Semver guidelines.

Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@rmouritzen-splunk
Copy link
Contributor

Looks good. I'll merge this without a version bump, since I'm about to merge and deploy another change.

@rmouritzen-splunk rmouritzen-splunk merged commit d4f2b03 into ocsf:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants