Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #104: Add category_uid to base of compiled class definition #105

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

rmouritzen-splunk
Copy link
Contributor

@rmouritzen-splunk rmouritzen-splunk commented Aug 6, 2024

Changes:

  • Issue Add category_uid to base of compiled class definitions #104: Add category_uid to base of compiled class definition.
  • Fix edge case with profiles using attributes with observable by attribute definitions. When "compiling" profile attributes, attributes with observable by dictionary attribute were not being copied to the profile's attributes. Basically the attribute's observable member needs to be copied.
  • Minor dependency updates.
  • Version bump to 2.73.0.

When "compiling" profile attributes, attributes with observable by dictionary attribute definitions were not being copied to the profile's attributes. This commit fixes that oversight.
@rmouritzen-splunk rmouritzen-splunk added the bug Something isn't working label Aug 6, 2024
@rmouritzen-splunk rmouritzen-splunk changed the title Fix edge case with profiles and attribute observable. Issue #104: Add category_uid to base of compiled class definition Aug 6, 2024
@rmouritzen-splunk rmouritzen-splunk added the enhancement New feature or request label Aug 6, 2024
@rmouritzen-splunk
Copy link
Contributor Author

rmouritzen-splunk commented Aug 6, 2024

FYI: @davemcatcisco , @dkolbly, and @query-jeremy.

This change adds category_uid to the base of each compiled class, as requested by Donovan Dave. The category_uid defaults to 0 for undefined or missing categories. This happens with base_event since it uses the other category, and other isn't defined in the schema -- it isn't defined in categories.json.

@rmouritzen-splunk rmouritzen-splunk merged commit a7ee6e9 into ocsf:main Aug 20, 2024
1 check passed
@rmouritzen-splunk rmouritzen-splunk deleted the profile-observable-fix branch August 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants