Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganise approach 1. #156

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Reorganise approach 1. #156

merged 5 commits into from
Sep 12, 2023

Conversation

calina-c
Copy link
Contributor

@calina-c calina-c commented Sep 8, 2023

Work on #137.

@calina-c calina-c marked this pull request as ready for review September 8, 2023 13:29
trentmc
trentmc approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I expected. +1

And nice optimize wrt deleting main1.py.

@calina-c calina-c merged commit c987c6e into main Sep 12, 2023
4 checks passed
@calina-c calina-c deleted the reorganise-approaches branch September 12, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentmc trentmc trentmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calina-c @trentmc