Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground dependencies and remove extras #1314

Merged
merged 15 commits into from
Feb 16, 2023
Merged

Ground dependencies and remove extras #1314

merged 15 commits into from
Feb 16, 2023

Conversation

calina-c
Copy link
Contributor

@calina-c calina-c commented Feb 6, 2023

Closes #1302. Closes #1305

Still pending:

  • update the classifier regarding release status from pre-alpha (to what?) -> see https://pypi.org/classifiers/
  • should we keep the original package author?
  • coloredlogs, used in testing settings, introduces both the dependency to coloredlogs and pyyaml to setup a yaml log file. I have never seen this file, are we using it? We should look into removing those dependencies if not essential, or at least downgrade them to dev/test dependencies if they belong there. (experimental branch exists for this)

@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 14:48 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 17:02 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 19:23 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 19:23 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 19:25 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 19:25 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 19:32 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 19:32 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 20:08 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 6, 2023 20:08 — with GitHub Actions Inactive
@calina-c calina-c marked this pull request as ready for review February 6, 2023 20:46
@calina-c calina-c changed the title [WIP] Ground dependencies and remove extras Ground dependencies and remove extras Feb 6, 2023
@trentmc trentmc temporarily deployed to CC_REPORTER_ID February 7, 2023 18:26 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 8, 2023 06:41 — with GitHub Actions Inactive
@LoznianuAnamaria
Copy link
Contributor

LoznianuAnamaria commented Feb 10, 2023

Blocker for: #1203

@trentmc
Copy link
Member

trentmc commented Feb 16, 2023

I'm fine with either of:

And I lean to (4) for now.

We can get to (5) when installing ocean.py is less finicky, which includes:

  • it's got so stable that the "install" readme can be just a single line pip install ocean-lib rather than half a page of gotchas & workarounds, AND
  • ocean.py runs out-of-the-box on anaconda (this is more useful than you may realize: once we have this, we can get teed up to be part of the conda distribution itself)

@trentmc
Copy link
Member

trentmc commented Feb 16, 2023

should we keep the original package author?

What's the motivation to change it?

FWIW, I think "leucothia" is hard to pronounce or understand why it's named that way. Better is "ocean-core-team" or something

@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 16, 2023 10:45 — with GitHub Actions Inactive
@calina-c calina-c temporarily deployed to CC_REPORTER_ID February 16, 2023 10:45 — with GitHub Actions Inactive
@calina-c calina-c merged commit 2936447 into main Feb 16, 2023
@calina-c calina-c deleted the dependency-work branch February 16, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants