Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table header for more clarity #36

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Conversation

bogdanfazakas
Copy link
Member

Fixes # .

Changes proposed in this PR:

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodes-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 7:14am

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as a short term improvement. The next step though should be to make the green tick / red cross based on if the node has 90% uptime. That way people will stress much less if they miss one check. We can move the "Last check" to the View More section

@bogdanfazakas
Copy link
Member Author

bogdanfazakas commented Sep 25, 2024

This is good as a short term improvement. The next step though should be to make the green tick / red cross based on if the node has 90% uptime. That way people will stress much less if they miss one check. We can move the "Last check" to the View More section

Yes we'll move towards that logic once the updated on the incentives announced yesterday start to take place, but as @mihaisc added yesterday we are going to continue for 2 more epochs with the current incentive logic so it does not make sense to have it already

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it's better than before at least

@bogdanfazakas
Copy link
Member Author

bogdanfazakas commented Sep 26, 2024

this is how it would look replacing the red cros sign with some warning orange color, we can revert if quickly if we want to keep the original version
Screenshot 2024-09-26 at 10 09 58

@bogdanfazakas bogdanfazakas merged commit 2bf3d09 into main Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants