Support virtual SQL for JSON TABLE #4
Conversation
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
| Session = sessionmaker(bind=self.engine) | ||
| session = Session() | ||
| new_meta_cache_items = [] | ||
| col_id = 16 |
There was a problem hiding this comment.
why does col_id starts with 16?
There was a problem hiding this comment.
The OceanBase user column ID also starts with 16, which can be considered an easter egg.
There was a problem hiding this comment.
There doesn't seem to be any problem, but it also doesn't feel very necessary.
| **kwargs, | ||
| ): | ||
| super().__init__(uri, user, password, db_name, **kwargs) | ||
| self.Base.metadata.create_all(self.engine) |
There was a problem hiding this comment.
Will this DDL work as expectation?
There was a problem hiding this comment.
DBA will create these two tables in advance so that even users without DDL permissions can use them normally.
| def refresh_metadata(self): | ||
| self.jmetadata.reflect(self.engine) | ||
|
|
||
| def perform_json_table_sql(self, sql: str): |
There was a problem hiding this comment.
Recommend to add type annotations for function return value
| if jtable_name in self.jmetadata.meta_cache: | ||
| raise ValueError("Table name duplicated") | ||
|
|
||
| Session = sessionmaker(bind=self.engine) |
There was a problem hiding this comment.
I think it would be better to declare the sessionmaker as an attribute of the client class.
| try: | ||
| session.commit() | ||
| self.jmetadata.meta_cache[jtable_name] = new_meta_cache_items | ||
| logger.info(f"ADD METADATA CACHE ---- {jtable_name}: {new_meta_cache_items}") |
There was a problem hiding this comment.
Maybe logger.debug is more appropriate here.
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
Signed-off-by: shanhaikang.shk <[email protected]>
| else: | ||
| ast.args['joins'] = [join_node] | ||
|
|
||
| extra_filter_str = f"user_id = {self.user_id} AND jtable_name = '{table_name}'" |
There was a problem hiding this comment.
Add a table name reference to avoid conflicts; for example, maybe user_id can exist in user-defined table
| Session = sessionmaker(bind=self.engine) | ||
| session = Session() | ||
| new_meta_cache_items = [] | ||
| col_id = 16 |
There was a problem hiding this comment.
There doesn't seem to be any problem, but it also doesn't feel very necessary.
Summary
Solution Description
introduce
sqlglot&pydanticinto pyobvector