Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(partition-plan): task's status is not as expected when error strategy is set to 'ignore any errors' #3805

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

yhilmare
Copy link
Contributor

@yhilmare yhilmare commented Nov 8, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

the task status will be set to 'sucess' even there are several errors in sql execution when we set 'ignore any errors' as the error process strategy which is not as expected.

Which issue(s) this PR fixes:

Fixes #3784

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Nov 8, 2024
@yhilmare yhilmare added this to the ODC 4.3.2 milestone Nov 8, 2024
@yhilmare yhilmare self-assigned this Nov 8, 2024
@yhilmare yhilmare linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@guowl3 guowl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 5a5453a into dev/4.3.2 Nov 8, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/shanlu_database_change_status_wrong branch November 8, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Status: Developed
Development

Successfully merging this pull request may close these issues.

[Bug]: the status for database change task is incorrect
3 participants