-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve(ui): improve generated types #930
base: master
Are you sure you want to change the base?
Conversation
王志超 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
49b2acd
to
91ee9cd
Compare
我应该没有变更 |
PR修复了LocalWrapper类型,能够正确推导出组件类型(此前一直是any),如果使用ob-desgin的项目此前组件传参不规范,升级后可能出现类型错误引发构建问题,是否应该考虑将此PR列入次要版本0.5.0? @dengfuping @linhf123 |
@linhf123 帮忙 Review 下吧 |
91ee9cd
to
0b49076
Compare
@dengfuping @linhf123 可以帮忙更新一下lock文件吗?我本地pnpm版本不一致,更新lock文件后差异太大了。 |
📦 Modified package
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
被LocalWrapper包裹的组件,在打包后类型都被推导成了any。
📝 Changelog
2. 修复ts错误
☑️ Self-Check before Merge