Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): DateRanger allowClear should work #929

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix(ui): DateRanger allowClear should work #929

merged 3 commits into from
Jan 14, 2025
+28 −12

Conversation

linhf123
Copy link
Collaborator

@linhf123 linhf123 commented Jan 13, 2025 •
edited by dengfuping
Loading

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #919

💡 Background and solution

Before After
image imageimage

📝 Changelog

Language Changelog
🇺🇸 English - support clear
🇨🇳 Chinese - 🐞 修复 DateRanger allowClear 不生效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 13, 2025 •
edited
Loading

@dengfuping dengfuping changed the title fix(DateRanger): Open Clear fix(ui): DateRanger allowClear should work Jan 14, 2025
@dengfuping dengfuping merged commit 9347202 into master Jan 14, 2025
6 checks passed
@linhf123 linhf123 deleted the linhf/fix--daterange-close branch January 15, 2025 02:50
@dengfuping dengfuping mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dengfuping dengfuping dengfuping requested changes

Assignees
No one assigned
Labels
bugfix DateRanger @oceanbase/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: DateRanger missing deletion function
2 participants
@linhf123 @dengfuping