Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(design): path resolve compatible with bigfish 3 #894

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

dengfuping
Copy link
Collaborator

@dengfuping dengfuping commented Dec 16, 2024

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Compatibility

🔗 Related issue link

💡 Background and solution

  • 之前为了解决 CodeSandbox 不支持 ~ 解析的问题,去掉了 ~ 路径。但在 Umi 3 & Bigfish 3 下路径解析有问题,需要改回去。
-@import 'antd/dist/reset.css';
+@import '~antd/dist/reset.css';

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese - 🐞 修复 antd 重置样式的引入路径 antd/dist/reset.css => ~antd/dist/reset.css,以适配 Umi 3 & Bigfish 3 的解析逻辑。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Dec 16, 2024

@dengfuping dengfuping merged commit 0c133ba into master Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant