Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(ui): DateRanger style #885

Merged
merged 10 commits into from
Dec 14, 2024
Merged

improve(ui): DateRanger style #885

merged 10 commits into from
Dec 14, 2024

Conversation

wzc520pyfm
Copy link
Collaborator

@wzc520pyfm wzc520pyfm commented Dec 12, 2024

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

  • None

💡 Background and solution

Before After
image image
image image

📝 Changelog

Language Changelog
🇺🇸 English 1. remove range picker icon
2. forward btn is no longer disabled & update text color
3. refresh is not supported when custom label is selected
4. fix style missing
5. add hover style
6. add quick time operation tooltip
7. time picker does not support cleared
8. support english date format
9. add min width is 1120
🇨🇳 Chinese 1. 移除时间图标
2. 不再禁用后退时间按钮
3. 刷新时间按钮在选中自定义时间时隐藏
4. 加回丢失的样式(优化按钮组边框)
5. 选择框增加 hover 样式
6. 前进/后退时间按钮添加 tooltip
7.时间选择组件不支持清空值
8. 支持英文格式日期时间
9. 优化选择框圆角和字体颜色。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dengfuping
❌ 王志超


王志超 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

github-actions bot commented Dec 12, 2024

@wzc520pyfm wzc520pyfm requested review from dengfuping and linhf123 and removed request for dengfuping December 12, 2024 09:24
@wzc520pyfm
Copy link
Collaborator Author

@linhf123 国际化和选错时间交互也需要补充在这里

@wzc520pyfm wzc520pyfm marked this pull request as draft December 13, 2024 02:53
: v.format(YEAR_DATE_TIME_SECOND_FORMAT);
? v.format(isCn ? YEAR_DATE_TIME_FORMAT_CN : YEAR_DATE_TIME_FORMAT)
: v.format(
isCn ? YEAR_DATE_TIME_SECOND_FORMAT_CN : YEAR_DATE_TIME_SECOND_FORMAT
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

日期时间格式在 locale 里有定义,可以直接使用,不用单独定义,可以参考 demo https://design.oceanbase.com/components/date-picker#packages-design-src-date-picker-demo-global-format

@@ -4,11 +4,14 @@

.@{prefix} {
cursor: pointer;
min-width: 1120px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最小宽度为 1120px 的原因是什么呢?

@dengfuping dengfuping changed the title fix(ui): [date-ranger] fix desgin acceptance improve(ui): DateRanger style Dec 13, 2024
@dengfuping dengfuping marked this pull request as ready for review December 14, 2024 11:00
@dengfuping dengfuping merged commit f3bc49c into master Dec 14, 2024
4 of 6 checks passed
@wzc520pyfm wzc520pyfm deleted the fix/date-ranger-desgin branch January 10, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants