fix syntax highlighting for module _ = and add syntax tests
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maelan
reviewed
Jan 29, 2023
syntax-testcases/functor1.ml
Outdated
| @@ -0,0 +1,19 @@ | |||
| module M : sig | |||
| module type F | |||
| = functor () (X : Ord) -> sig end (* not ok *) | |||
There was a problem hiding this comment.
This comment and the other ones in this file refer to linting as it was done before PR #95. Now all these tests work.
There was a problem hiding this comment.
Some of the equal signs seem to not be highlighted, but I guess that's a minor issue.
|
Perhaps leave a reference to relevant GitHub issue/pull numbers in comments? |
Good idea, I've linked the broken tests to open issues. |
|
Merging, as tests should be fine and the fix is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Maelan