Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate opam file with Dune #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generate opam file with Dune #62

wants to merge 1 commit into from

Conversation

smorimoto
Copy link
Member

  • Generate opam file with Dune
  • Update menhir extension to 3.0

@smorimoto
Generate opam file with Dune
ee30440 
Signed-off-by: Sora Morimoto <[email protected]>
kit-ty-kate
kit-ty-kate requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning behind this change?
Imo this gives us more work for no improvements, worse the generated file has superfluous steps and can sometimes be buggy. I'm personally wholly against it.

@smorimoto
Copy link
Member Author

I was trying to enable some flags by bumping to Menhir extension 3.0. We could just enable it.

@kit-ty-kate
Copy link
Member

I was trying to enable some flags by bumping to Menhir extension 3.0. We could just enable it.

Looking into it, it seems that it only brings the (explain ...) field. I personally see little use to enable it all the time. I don't think it makes it worth bumping the minimum required version of dune just for something developers would use. This can very well stay a local change without forcing everyone using opam-file-format (including distributions that do not have dune 3.17) to upgrade to dune 3.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smorimoto @kit-ty-kate