Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More misc fixes #1275

Merged
merged 7 commits into from
Jan 15, 2025
Merged

More misc fixes #1275

merged 7 commits into from
Jan 15, 2025

Conversation

jonludlam
Copy link
Member

  • The custom-layout option is for 'monorepo mode'
  • As is the short-title option
  • The duplicates problem is causing bug in trunk right now
  • The fix for Cmx_format is only helpful in 'monorepo mode'
  • The versions thing and the global_config fixes come up when building in 'normal mode' when in a dune repo

This disables the checks that the package and library paths are disjoint. This
is intended to be for more interesting layouts such as that being developed
in the currently-named 'monorepo' mode.
As it happens we only need the cmi file `Cmx_format` and it's in a directory shared
by another library we need.
The version installed in opam can be different from the version in the current
dune _build/install dir.
@jonludlam jonludlam added the no changelog This pull request does not need a changelog entry label Jan 15, 2025
@jonludlam jonludlam mentioned this pull request Jan 15, 2025
Copy link
Collaborator

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge!

@@ -222,7 +222,7 @@ end = struct

let compile hidden directories resolve_fwd_refs dst output_dir package_opt
parent_name_opt parent_id_opt open_modules children input warnings_options
unique_id =
unique_id short_title =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect for making the experience consistent on every packages. The short title can be removed from doc/index.mld when the driver start to use this flag.

@jonludlam jonludlam merged commit cd7b18b into ocaml:master Jan 15, 2025
13 of 15 checks passed
@jonludlam
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants