Don't enable the -with-relative-paths-at in opam
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present - with switches which cannot be moved anyway - this adds a potential source of brittleness to opam switches without bringing any benefit.
|
Agree. This is too much for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. ocaml/opam-repository#26864 (review).
The setup using an environment variable is clearly beneficial to Dune's experimental package management feature, but I don't think it's a good thing to turn on at present for all opam-repository users (especially given both @MSoegtropIMC and @jonahbeckford's concerns). It causes
ocamlfindto depend on theOPAM_SWITCH_PREFIXenvironment variable being correct, which at present it does not. Given that opam itself can't do any kind of caching or relocation (at least at present), it doesn't seem to bring any benefit with that increased brittleness.cc @Leonidas-from-XIV - there are a couple of mechanisms available which could allow this option to be enabled explicitly by a user, if it would be helpful for Dune p.m.? (very happy to help with that).